garden-runc: init at 1.17.1 #60071
Closed
garden-runc: init at 1.17.1 #60071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very interesting - I wonder if this could ever lead to cloudfoundry in nixpkgs... On that note, I realize this originated from a concourse PR, but I'd argue that |
ryantm
requested changes
Jan 3, 2020
| let | ||
| version = "1.17.1"; | ||
|
|
||
| garden_src = fetchgit { |
There was a problem hiding this comment.
Please use fetchFromGitHub because
- It is more efficient
- It allows us to fix GitHub specific issues
|
|
||
| gdn = | ||
| stdenv.mkDerivation rec { | ||
| name = "garden-runc"; |
There was a problem hiding this comment.
Suggested change
| name = "garden-runc"; | |
| pname = "garden-runc"; |
| { stdenv, glibc, garden_src }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "init"; |
There was a problem hiding this comment.
Suggested change
| name = "init"; | |
| pname = "garden-runc-init"; |
| }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "nstar"; |
There was a problem hiding this comment.
Suggested change
| name = "nstar"; | |
| pname = "garden-runc-nstar"; |
| ''; | ||
| }; | ||
| in | ||
| runCommand "wrapped-garden-runc" { |
There was a problem hiding this comment.
Is it possible to use makeWrapper in the above derivation instead of this additional wrapper derivation?
|
Closing because unmaintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Continuing to break up #53691
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)