go-packr: init at 1.13.7 #60069
go-packr: init at 1.13.7 #60069
Conversation
ofborg
bot
added
8.has: package (new)
|
packr has been updated to v2. Should that be packaged instead? |
| { stdenv, buildGoPackage, fetchgit }: | ||
|
|
||
| buildGoPackage rec { | ||
| name = "go-packr-${version}"; |
There was a problem hiding this comment.
| name = "go-packr-${version}"; | |
| pname = "go-packr"; |
|
|
||
| goDeps = ./deps.nix; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Please use fetchFromGitHub because
- It is more efficient
- It allows us to fix GitHub specific issues
| }; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| license = licenses.mit; |
There was a problem hiding this comment.
Please add meta.description and meta.homepage.
|
|
||
| buildGoPackage rec { | ||
| name = "go-packr-${version}"; | ||
| version = "v1.13.7"; |
There was a problem hiding this comment.
Please update to the latest stable version currently "2.7.1".
| version = "v1.13.7"; | |
| version = "2.7.1"; |
| goDeps = ./deps.nix; | ||
|
|
||
| src = fetchgit { | ||
| inherit rev; |
There was a problem hiding this comment.
| inherit rev; | |
| rev = "v${version}"; |
| buildGoPackage rec { | ||
| name = "go-packr-${version}"; | ||
| version = "v1.13.7"; | ||
| rev = "5a2cbb54c4e7d482e3f518c56f1f86f133d5204f"; |
There was a problem hiding this comment.
| rev = "5a2cbb54c4e7d482e3f518c56f1f86f133d5204f"; |
|
Hey @ryantm thanks for reviewing the PR, I appreciate the feedback :) Unfortunately my company has deprecated concourse internally and thus this PR has gone unmaintained. How would you suggest we proceed? Should we fix these last issues and merge it, or do you think we should close it until someone else finds a need for it? |
|
@edude03 Personally, I think of myself as a radical inclusionist and would want everything packaged if possible, but, I think most people expect packaged things to have a maintainer, so it is probably best to close it until someone else who wants to maintain it adds it back. |
|
Closing because unmaintained |
Motivation for this change
Breaking up #53691 into nice commits / PRs.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)