Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_7: 7.0.1 -> 7.1.0 #60068

Merged
merged 2 commits into from Apr 26, 2019
Merged

llvmPackages_7: 7.0.1 -> 7.1.0 #60068

merged 2 commits into from Apr 26, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 23, 2019

Motivation for this change

Fixy fixes, primarily a particularly gnarly issue.

Eep, my writing-fu is weak right now sorry!

Things done

Still testing, FWIW. :)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Apr 23, 2019

Hmm, upstream posted no announcement nor link from the web :-/ BTW, I expect the rebuild amount is too high for direct merge to master.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 24, 2019 via email

@vcunat
Copy link
Member

vcunat commented Apr 24, 2019

I don't think we need to wait for that, but the amount of rebuilds is high, so it probably shouldn't go directly to master anyway.

@dtzWill dtzWill changed the base branch from master to staging April 26, 2019 03:51
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: stdenv Standard environment labels Apr 26, 2019
@ofborg ofborg bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: stdenv Standard environment 8.has: documentation 8.has: module (update) labels Apr 26, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

https://github.com/llvm/llvm-project/compare/llvmorg-7.0.1..llvmorg-7.1.0

Yep, it's entirely the official fix version of the patch we were using-- well, that and bits involved in changing the version number xD.

So definitely looks good, and indeed should be sent to staging (which I just fixed now). Thanks!

@matthewbauer
Copy link
Member

We're seeing this failure on aarch64:

https://hydra.nixos.org/job/nixpkgs/staging-next/llvm_7.aarch64-linux

@dtzWill
Copy link
Member Author

dtzWill commented May 1, 2019

We're seeing this failure on aarch64:

https://hydra.nixos.org/job/nixpkgs/staging-next/llvm_7.aarch64-linux

Well that's no good, sorry!

Thoughts so far:

  • If needed, we can disable llvm-exegesis / don't provide libpfm: neat utility but compared to having a working clang/libLLVM is by comparison unimportant.
  • It's strange this started happening with the update? The only change, AFAICT, we weren't already using is the new minor version number (and propagating it through the code). Take a look: https://github.com/llvm/llvm-project/compare/llvmorg-7.0.1..llvmorg-7.1.0 .
  • Our aarch64 builder has an awesome number of cores, which sometimes causes problems we don't see elsewhere. I don't see that being the cause here, though...

Oh, that's right-- this has happened before and disappeared, apparently?

#56245

Dunno, but thanks for the ping!

@dtzWill
Copy link
Member Author

dtzWill commented May 2, 2019

So looking at the test in question... it looks like it wants to check basic perf events fire, but it tests with the execution of a literally empty lambda (?!):

https://github.com/llvm/llvm-project/blob/1feaee52ff70948747251d83690de3ee35709a61/llvm/unittests/tools/llvm-exegesis/PerfHelperTest.cpp#L26

Perhaps it's intentionally testing the edge case ("ensure at least one event is triggered")?

Brainstorming-style, do we know that this builder supports performance counters? Cloud infrastructure often has limited support for this, no clue what the situation is with aarch64 but that might be worth checking.

@dtzWill
Copy link
Member Author

dtzWill commented May 2, 2019

Alright, I think I have something! cc @grahamc re:arm builders and Packet-relatedness.
This is a bit of a long-shot but here we go...

... do we know what kernel we're running on these? ^_^

EDIT: last successful build was on a different type machine, which is promising! Builder was packet-t2a5-qc-centriq-1. ( https://hydra.nixos.org/build/92610201#tabs-buildsteps )

@matthewbauer
Copy link
Member

Ah ok! I just saw that the version change and assumed it was new. It looks like it's been happening on a few past builds as well

@matthewbauer
Copy link
Member

matthewbauer commented May 3, 2019

@dtzWill Another issue that may not be directly related to this update but looks to be caused by the version bump:

https://hydra.nixos.org/build/92930990/nixlog/3/tail

--- stderr
llvm-config: error: libLLVM-7.1.dylib is missing
thread 'main' panicked at 'command did not execute successfully: "/nix/store/5ffmj0j7px7xwawrb25bwxxhab633gvg-llvm-7.1.0/bin/llvm-config" "--link-shared" "--libs" "--system-libs" "aarch64" "amdgpu" "arm" "asmparser" "bitreader" "bitwriter" "hexagon" "instrumentation" "interpreter" "ipo" "linker" "lto" "mcjit" "mips" "msp430" "nvptx" "powerpc" "sparc" "systemz" "webassembly" "x86"
expected success, got: exit code: 1', src/build_helper/lib.rs:134:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

Maybe some patch in the llvm script needs to be updated?

@LnL7
Copy link
Member

LnL7 commented May 4, 2019

@matthewbauer I'm already working on that one.

@wizeman
Copy link
Member

wizeman commented May 6, 2019

The performance counters test failure (issue #56245) also occurred when I tried to build llvm 7.0.1 on a Raspberry Pi 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants