New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_7: 7.0.1 -> 7.1.0 #60068
Conversation
Hmm, upstream posted no announcement nor link from the web :-/ BTW, I expect the rebuild amount is too high for direct merge to master. |
Hopefully they follow soon :).
Tagged ~11d ago:
http://lists.llvm.org/pipermail/release-testers/2019-April/000946.html
Official source tarballs posted ~6d ago:
http://llvm.org/viewvc/llvm-project?view=revision&revision=358580
Looks like mostly waiting on folks to generate and upload platform
binaries, but just a guess.
We can sit on this for a few days, see if things are wrapped up by then
:)
…On Tue, 23 Apr 2019 06:43:46 +0000 (UTC), Vladimír Čunát ***@***.***> wrote:
Hmm, upstream posted no announcement nor link from the web :-/
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#60068 (comment) part: text/html
|
I don't think we need to wait for that, but the amount of rebuilds is high, so it probably shouldn't go directly to master anyway. |
https://github.com/llvm/llvm-project/compare/llvmorg-7.0.1..llvmorg-7.1.0 Yep, it's entirely the official fix version of the patch we were using-- well, that and bits involved in changing the version number xD. So definitely looks good, and indeed should be sent to staging (which I just fixed now). Thanks! |
We're seeing this failure on aarch64: https://hydra.nixos.org/job/nixpkgs/staging-next/llvm_7.aarch64-linux |
Well that's no good, sorry! Thoughts so far:
Oh, that's right-- this has happened before and disappeared, apparently? Dunno, but thanks for the ping! |
So looking at the test in question... it looks like it wants to check basic perf events fire, but it tests with the execution of a literally empty lambda (?!): Perhaps it's intentionally testing the edge case ("ensure at least one event is triggered")? Brainstorming-style, do we know that this builder supports performance counters? Cloud infrastructure often has limited support for this, no clue what the situation is with aarch64 but that might be worth checking. |
Alright, I think I have something! cc @grahamc re:arm builders and Packet-relatedness.
... do we know what kernel we're running on these? ^_^ EDIT: last successful build was on a different type machine, which is promising! Builder was |
Ah ok! I just saw that the version change and assumed it was new. It looks like it's been happening on a few past builds as well |
@dtzWill Another issue that may not be directly related to this update but looks to be caused by the version bump: https://hydra.nixos.org/build/92930990/nixlog/3/tail
Maybe some patch in the llvm script needs to be updated? |
@matthewbauer I'm already working on that one. |
The performance counters test failure (issue #56245) also occurred when I tried to build llvm 7.0.1 on a Raspberry Pi 3. |
Motivation for this change
Fixy fixes, primarily a particularly gnarly issue.
Eep, my writing-fu is weak right now sorry!
Things done
Still testing, FWIW. :)
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)