Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages: add prefix 'php-' to packages #60099

Merged
merged 1 commit into from Apr 24, 2019
Merged

phpPackages: add prefix 'php-' to packages #60099

merged 1 commit into from Apr 24, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 23, 2019 •
edited

Motivation for this change

Aadd prefix 'php-' to php packages
See - #59904 (comment)

cc @etu @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from etu April 23, 2019 17:17
@aanderse
Copy link
Member

@GrahamcOfBorg build phpPackages.psysh phpPackages.phpstan

aanderse
aanderse approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/nix/store/v27xvvrmassl2d6l6l4a6jqav500mvb6-php-psysh-0.9.9
/nix/store/ga0aghvr9yzyiphb6nkn216ivhq5x4fb-php-phpstan-0.11.5

@Izorkin so did these 2 packages just get missed in the last PR it looks like? So all packages are renamed now? LGTM 👍

@etu etu merged commit 0620e0f into NixOS:master Apr 24, 2019
@etu
Copy link
Contributor

etu commented Apr 24, 2019

@Izorkin Thanks :-)

@aanderse Yeah, most packages use buildPecl which adds it, so the file is going to be a mixture... Maybe one could wrap mkDerivation for that file and not call it directly from stdenv all the time and just prepend the pname with "php-", that would make the file more consistent overall :-)

@Izorkin Izorkin deleted the php-packages-prefix branch April 24, 2019 05:57
@aanderse
Copy link
Member

Right! that makes sense.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2019

Yes, missed this packages.

@etu etu mentioned this pull request Apr 24, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @aanderse @etu