Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto: 1.5.8 -> 1.6 + nixos tests #60149

Merged
merged 2 commits into from Apr 24, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

https://github.com/eclipse/mosquitto/blob/master/ChangeLog.txt

Also we need some kind of test in place - this is very basic but better than nothing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use nixos/mosquitto for the commit message.

@peterhoeg
Copy link
Member Author

Fixed @dotlambda

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg test mosquitto

@dotlambda
Copy link
Member

@GrahamcOfBorg test home-assistant

@peterhoeg peterhoeg merged commit f81ddbf into NixOS:master Apr 24, 2019
@peterhoeg peterhoeg deleted the u/mosquitto_160 branch April 24, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants