Skip to content

rustfmt: 1.0.1 -> 1.2.1 #60085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2019
Merged

rustfmt: 1.0.1 -> 1.2.1 #60085

merged 2 commits into from
Apr 23, 2019
+5 −4

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 23, 2019

Motivation for this change

Fixes the build after the rustc 1.34.0 update in
#59366.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@timokau
rustfmt: 1.0.1 -> 1.2.1
ac938fd 
Fixes the build after the rustc 1.34.0 update in
NixOS#59366.
@ofborg ofborg bot requested a review from globin April 23, 2019 10:51
@timokau
Copy link
Member Author

timokau commented Apr 23, 2019

The darwin failure seems novel. Just marking as broken for now, since being broken on darwin is still better than being broken on all platforms.

@NixOS/darwin-maintainers care to have a look?

@timokau timokau mentioned this pull request Apr 23, 2019
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Apr 23, 2019

The build log is vanished so.

@timokau
Copy link
Member Author

timokau commented Apr 23, 2019

I assume people with darwin hardware will be able to reproduce the issue.

@timokau timokau merged commit f053d74 into NixOS:master Apr 23, 2019
@timokau timokau deleted the rustfmt-update branch April 23, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @Mic92