librecad: add .desktop file and icon #60008
Conversation
|
Nice, thanks! I didn't check whether the icons show up but the directories are correct. Just an optional suggestion, you could use |
Thanks, I'll probably do that going forward (I've been adding XDG files to a bunch of packages which are missing them). If you'd rather see this switched over to use |
|
I personally think it's clearer and less cluttery. You can immediately see that the file is copied to the directory you're creating. |
Use the .desktop file and app icon included in the source package.
lightbulbjim
force-pushed
the
librecad-desktop
branch
from
531b093
to
2236fe0
Compare
|
Fair enough. I've updated it to use |
| @@ -18,8 +18,11 @@ stdenv.mkDerivation rec { | |||
| qmakeFlags = [ "MUPARSER_DIR=${muparser}" "BOOST_DIR=${boost.dev}" ]; | |||
|
|
|||
| installPhase = '' | |||
| mkdir -p $out/bin $out/share | |||
| cp -R unix/librecad $out/bin | |||
There was a problem hiding this comment.
was there a single binary ? the new version just keeps bin/librecad.
There was a problem hiding this comment.
Yes there was, not sure why they used -R before.
There was a problem hiding this comment.
Correct, the only file in bin is librecad.
|
built it into nix-review. Looked fine. I didn't how to check for the icon until I realized rofi supported it. I enabled the feature and it showed so merging. |
Motivation for this change
Use the .desktop file and app icon included in the source package.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)