nixos-container: allow setting custom local and host address #60029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a nixops network where I deploy containers using the `container`
backend which uses `nixos-container` intenrally to deploy several
containers to a certain host.
During that time I removed and added new containers and while trying to
deploy those to a different host I realized that it isn't guaranteed
that each container gets the same IP address which is a problem as some
parts of the deployment need to know which container is using which IP
(i.e. to configure port forwarding on the host).
With this change you can specify the container's IP like this (and don't
have to use the arbitrarily used 10.233.0.0/16 subnet):
```
$ nixos-container create test --config-file test-container.nix \
--local-address 10.235.1.2 --host-address 10.235.1.1
```
Ma27
force-pushed
the
configure-ipv4-for-imperative-container
branch
from
ca44921
to
c957341
Compare
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/9 |
danbst
approved these changes
Jun 4, 2019
Full ack, in fact I'm planning to do this in the long term (and fix the container backend of nixops accordingly). I'm not sure how far I'll go then, but this was (at least for me) the biggest issue I had and I was motivated to fix it to get a bit more familiar the the code :) |
Ma27
added a commit
to Ma27/nixops
that referenced
this pull request
Jun 13, 2019
With that patch it's possible to deploy containers and assign them to
different IPs than the next available one from `10.233.0.0/16`. This
patch depends on #60029[1] and can only be used with NixOS 19.09
(a.k.a nixos-unstable at the time of writing).
The behavior can be tested using a simple deployment like this:
``` nix
{
container = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
deployment.container.localAddress = "10.235.1.2";
deployment.container.hostAddress = "10.235.1.1";
};
# the feature is optional, by default the next free addresses
# from 10.233.0.0/16 will be used here.
container2 = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
};
horst = { ... }:
{ deployment.targetEnv = "libvirtd";
};
}
```
[1] NixOS/nixpkgs#60029
Ma27
added a commit
to Ma27/nixops
that referenced
this pull request
Jun 13, 2019
With that patch it's possible to deploy containers and assign containers to
different IPs rather than the next available /24 subnet from `10.233.0.0/16`.
This patch depends on #60029[1] and can only be used with NixOS 19.09
(a.k.a nixos-unstable at the time of writing).
The behavior can be tested using a simple deployment like this:
``` nix
{
container = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
deployment.container.localAddress = "10.235.1.2";
deployment.container.hostAddress = "10.235.1.1";
};
# the feature is optional, by default the next free addresses
# from 10.233.0.0/16 will be used here.
container2 = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
};
horst = { ... }:
{ deployment.targetEnv = "libvirtd";
};
}
```
[1] NixOS/nixpkgs#60029
Ma27
added a commit
to Ma27/nixops
that referenced
this pull request
Jun 13, 2019
With that patch it's possible to deploy containers and assign those to
different IPs rather than the next available /24 subnet from `10.233.0.0/16`.
This patch depends on #60029[1] and can only be used with NixOS 19.09
(a.k.a nixos-unstable at the time of writing).
The behavior can be tested using a simple deployment like this:
``` nix
{
container = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
deployment.container.localAddress = "10.235.1.2";
deployment.container.hostAddress = "10.235.1.1";
};
# the feature is optional, by default the next free addresses
# from 10.233.0.0/16 will be used here.
container2 = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
};
horst = { ... }:
{ deployment.targetEnv = "libvirtd";
};
}
```
[1] NixOS/nixpkgs#60029
Ma27
added a commit
to Ma27/nixops
that referenced
this pull request
Jun 14, 2019
With that patch it's possible to deploy containers and assign those to
different IPs rather than the next available /24 subnet from `10.233.0.0/16`.
This patch depends on #60029[1] and can only be used with NixOS 19.09
(a.k.a nixos-unstable at the time of writing).
The behavior can be tested using a simple deployment like this:
``` nix
{
container = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
deployment.container.localAddress = "10.235.1.2";
deployment.container.hostAddress = "10.235.1.1";
};
# the feature is optional, by default the next free addresses
# from 10.233.0.0/16 will be used here.
container2 = { resources, ... }:
{ deployment.targetEnv = "container";
deployment.container.host = resources.machines.horst;
};
horst = { ... }:
{ deployment.targetEnv = "libvirtd";
};
}
```
[1] NixOS/nixpkgs#60029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I have a nixops network where I deploy containers using the
containerbackend which uses
nixos-containerintenrally to deploy severalcontainers to a certain host.
During that time I removed and added new containers and while trying to
deploy those to a different host I realized that it isn't guaranteed
that each container gets the same IP address which is a problem as some
parts of the deployment need to know which container is using which IP
(i.e. to configure port forwarding on the host).
With this change you can specify the container's IP like this (and don't
have to use the arbitrarily used 10.233.0.0/16 subnet):
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)