Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS urls #60010

Merged
merged 2 commits into from Apr 22, 2019
Merged

HTTPS urls #60010

merged 2 commits into from Apr 22, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Lots of URLs were HTTP redirect to HTTPS. Changed those and checked them
if there's actual content. Inspired by #60004

They're mostly homepage URLs so there are probably a lot of source URLs left on HTTP which we should fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
treewide: Change URLs to HTTPS
bac4d95 
Lots of URLs were HTTP redirect to HTTPS. Changed those and checked them
if there's actual content. Inspired by
NixOS#60004
@JohnAZoidberg JohnAZoidberg changed the title Https urls HTTPS urls Apr 22, 2019
rycee
rycee approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tried a bunch of random links and they worked fine. Thanks!

@infinisil
Copy link
Member

For reference, previous efforts for moving to https (list might not be complete): #13809 #30906 #34836 #42665 #42676 #50989 #51001 #51329

@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Apr 22, 2019 •
edited

If found pretty much all of those because repology said they automatically redirect to HTTPS when you try to access HTTP: https://repology.org/repository/nix_unstable/problems

And almost all of them are the homepage attribute. That's probably why they weren't included in previous refactors.

matthewbauer
matthewbauer approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Moving fetchurl to https is not as important because we have hashes to ensure integrity, but it also doesn't hurt.

@infinisil
Copy link
Member

@matthiasbeyer It's important for whenever somebody updates the hashes

@matthiasbeyer
Copy link
Contributor

@infinisil you wanted @matthewbauer probably.

markuskowa
markuskowa reviewed Apr 22, 2019
View reviewed changes
pkgs/applications/editors/eclipse/plugins.nix Outdated
sha256 = "022phbrsny3gb8npb6sxyqqxacx138q5bd7dq3gqxh3kprx5chbl";
})
];

propagatedBuildInputs = [ zest ];

meta = with stdenv.lib; {
homepage = http://www2.cs.tum.edu/projects/cup/eclipse.php;
homepage = https://www2.cs.tum.edu/projects/cup/eclipse.php;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is dead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, how did I miss that? Seems like they support HTTPS but have different content there.

@markuskowa markuskowa merged commit d0e70ac into NixOS:master Apr 22, 2019
@JohnAZoidberg JohnAZoidberg deleted the https-urls branch April 22, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa left review comments

@matthewbauer matthewbauer matthewbauer approved these changes

@rycee rycee rycee approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: lua 6.topic: nixos 6.topic: python 6.topic: xfce The Xfce Desktop Environment 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@JohnAZoidberg @infinisil @matthiasbeyer @matthewbauer @rycee @vcunat @c0bw3b @markuskowa @GrahamcOfBorg