Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weechatScripts.weechat-autosort: unstable-2018-01-11 -> 3.4 #60009

Merged
merged 1 commit into from Apr 22, 2019
Merged

weechatScripts.weechat-autosort: unstable-2018-01-11 -> 3.4 #60009

merged 1 commit into from Apr 22, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Apr 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir dywedir requested a review from Ma27 April 22, 2019 08:37
@Ma27
Copy link
Member

Ma27 commented Apr 22, 2019

LGTM. Will test and merge later that day 👍

@Ma27 Ma27 merged commit 7b28e23 into NixOS:master Apr 22, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 22, 2019

@dywedir thanks!

@dywedir dywedir deleted the weechat-autosort branch April 22, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @Ma27 @GrahamcOfBorg