Backport perl: add .withPackages #59215 #60028 #60037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 03eaa48)
fix NixOS#59215 (comment) (cherry picked from commit f73eb61)
(cherry picked from commit d23ff47)
give priority to perl libraries when they meet the perl derivation in `buildEnv`. The notable case is `buildEnv` inside `perl.withPackages`. The `perl' derivation includes obsolete versions of some CPAN packages which leads to collissions when there are newer versions of the same libraries are on the right hand side of `perl.withPackages` (perhaps indirectly). Fixes NixOS#60025 (cherry picked from commit 0fad0b4)
aanderse
approved these changes
Apr 22, 2019
There was a problem hiding this comment.
After adding the missing self = perldevel; reference @volth mentioned, building my system against this branch, and then testing a few select perl scripts against an environment.systemPackages = [ perl.withPackages... ]; (both perl and perldevel), I feel pretty good that this is working as expected without any obvious regressions.
|
@samueldr I'm leaving final approval and merging to you for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #59215 and #60028 to 19.03
Undraft and merge only once #60028 has been validated and merged, please.
The initial commit (perl: add .withPackages) had two conflicts. The first one is a possibly missing perl update to stable (?) and the second one was with the signature where I think a cross-compilation change changed it (trivial to fix).
cc @volth