Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kipi-plugins: 5.9.0 -> 5.9.1, build from dedicated tarball #60039

Merged
merged 1 commit into from Apr 23, 2019
Merged

kipi-plugins: 5.9.0 -> 5.9.1, build from dedicated tarball #60039

merged 1 commit into from Apr 23, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 22, 2019

Motivation for this change

Update. Also,

Don't pick out from digikam's source.
(presumably the plugins used to live there primarily?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
kipi-plugins: 5.9.0 -> 5.9.1, build from dedicated tarball
18defa9 
Don't pick out from digikam's source.
(presumably the plugins used to live there primarily?)
@ofborg ofborg bot requested a review from ttuegel April 22, 2019 20:27
@ttuegel ttuegel merged commit 4009dfd into NixOS:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @ttuegel