Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsForQt5.qca-qt5: 2.1.3 -> 2.2.1 #60043

Merged
merged 6 commits into from Apr 28, 2019
Merged

libsForQt5.qca-qt5: 2.1.3 -> 2.2.1 #60043

merged 6 commits into from Apr 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 22, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the title <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! --> ###### Motivation for this change libsForQt5.qca-qt5: 2.1.3 -> 2.2.0 Apr 22, 2019
@ofborg ofborg bot requested a review from ttuegel April 22, 2019 20:59
@dtzWill dtzWill changed the title libsForQt5.qca-qt5: 2.1.3 -> 2.2.0 libsForQt5.qca-qt5: 2.1.3 -> 2.2.1 Apr 27, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Apr 27, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build libsForQt5.qca-qt5

@dtzWill
Copy link
Member Author

dtzWill commented Apr 27, 2019

Fixed darwin build \o/. Unfortunately seems borg fails in eval for some reason-- I don't think it's a problem w/this PR?

@dtzWill dtzWill merged commit 6eaf738 into NixOS:master Apr 28, 2019
@dtzWill dtzWill deleted the update/qca-qt5-2.2.0 branch April 28, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @ttuegel