Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.battery-status: mark as not broken #59996

Closed
wants to merge 1 commit into from
Closed

gnomeExtensions.battery-status: mark as not broken #59996

wants to merge 1 commit into from

Conversation

jonafato
Copy link
Contributor

Motivation for this change

This extension does not declare support for GNOME 3.32 (or any other
recent version), but it does work. I've opened an upstream pull
request to address this. Additionally, add meta.platforms and update
the homepage and GitHub owner to reflect the user that milliburn
redirects to.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 22, 2019 •
edited

@jonafato can you apply said patch here?

@jonafato
gnomeExtensions.battery-status: mark as not broken
ec6c59b 
This extension does not declare support for GNOME 3.32 (or any other
recent version), but it does work. I've opened an [upstream pull
request] to address this. Additionally, add `meta.platforms` and update
the homepage and GitHub owner to reflect the user that `milliburn`
redirects to.

[upstream pull request]: roberth-k/gnome-shell-extension-battery_status#18
@jonafato jonafato force-pushed the gnomeExtensions.battery-status-unbreak branch from f3638c5 to ec6c59b Compare April 22, 2019 02:00
@jonafato
Copy link
Contributor Author

@worldofpeace Updated.

@worldofpeace
Copy link
Contributor

Hmm, somehow a metadata.json.oriq ends up in the output?

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@piegamesde
Copy link
Member

It looks like the extension has been abandoned for a while now.

@piegamesde piegamesde closed this Sep 9, 2021
@jonafato jonafato deleted the gnomeExtensions.battery-status-unbreak branch September 9, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonafato @worldofpeace @piegamesde @ryantm @GrahamcOfBorg