Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages: Wrap mkDerivation to prepend package names #60155

Merged
merged 1 commit into from Apr 25, 2019
Merged

phpPackages: Wrap mkDerivation to prepend package names #60155

merged 1 commit into from Apr 25, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 24, 2019

Motivation for this change

This will make the file more consistent and easier to follow when we
have a mixture of buildPecl (which already does this) and straight up
regular derivations.

This is a followup from #60099.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
phpPackages: Wrap mkDerivation to prepend package names
06e0ede 
This will make the file more consistent and easier to follow when we
have a mixture of buildPecl (which already does this) and straight up
regular derivations.
@etu etu requested review from jtojnar and aanderse April 24, 2019 11:12
aanderse
aanderse approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping this is a good idea as it will prevent us from having inconsistent naming. LGTM 👍

@aanderse aanderse merged commit dc1716f into NixOS:master Apr 25, 2019
@etu etu deleted the prepend-phpPackages-names branch April 25, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar jtojnar is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @aanderse