rtl8821au: update for Linux 5.0 #60072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we can have the version be |
|
I'm sorry for the late response.
This is a notation I've never seen before, but I've implemented it as suggested. |
NeQuissimus
approved these changes
May 6, 2019
veprbl
approved these changes
May 27, 2019
There was a problem hiding this comment.
From nix-review:
6 package failed to build:
linuxPackages-libre.rtl8821au linuxPackages_5_1.rtl8821au linuxPackages_latest-libre.rtl8821au linuxPackages_latest_hardened.rtl8821au linuxPackages_latest_xen_dom0.rtl8821au linuxPackages_testing_hardened.rtl8821au
8 package were build:
linuxPackages.rtl8821au linuxPackages_4_14.rtl8821au linuxPackages_4_4.rtl8821au linuxPackages_4_9.rtl8821au linuxPackages_5_0.rtl8821au linuxPackages_hardened.rtl8821au linuxPackages_testing_bcachefs.rtl8821au linuxPackages_xen_dom0.rtl8821au
linuxPackages_5_1.rtl8821au is currently broken on Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/linuxPackages_5_1.rtl8821au.x86_64-linux
veprbl
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've upgraded to NixOS 19.03 and this was the only issue.
This change is simple enough, but the lack of a version change upstream puts this in the same spot as the rtl8814au driver. The nixpkgs manual doesn't seem to contain a policy for this - is it even a problem?