prometheus-statsd-exporter: 0.4.0 -> 0.9.0 #59983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build prometheus-statsd-exporter |
|
I think it also makes sense to remove the prometheus-statsd-bridge alias now because the package really has become a different thing. |
The executable name and arguments are different in prometheus-statsd-exporter.
|
Thanks, removed the alias. Heads up @jbgi, this upgrade will break your https://github.com/input-output-hk/iohk-ops/pull/558/files#diff-b6b843ae5c2dd45366d561553ddecbd9R75 |
|
Thanks @ivan for heads up, will keep in mind when we upgrade to 19.09. (unless there is a plan to backport this?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/prometheus/statsd_exporter/releases
Note that the output binary has changed from
statsd_bridgetostatsd_exporterand that the command-line arguments have changed.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)I sent a counter to it over UDP and it seemed to work.