@GrahamcOfBorg build gitea nixosTests.gitea

should this be backported as there are security fixes ?

@nyanloutre Hard to say since gitea tend to sometimes break things in minor versions... But they also abandon minor versions quite fast...

I think this breaks with databases other than sqlite right now, but I'm not 100% sure.

gitea[22208]: panic: default addr for network '/var/lib/gitea/data' unknown
gitea[22208]: goroutine 1 [running]:
gitea[22208]: code.gitea.io/gitea/vendor/github.com/go-macaron/session.Sessioner(0xc000607560, 0x1, 0x1, 0x8, 0x9)
gitea[22208]:     /build/go/src/code.gitea.io/gitea/vendor/github.com/go-macaron/session/session.go:155 +0x23e
gitea[22208]: code.gitea.io/gitea/routers/routes.NewMacaron(0xc0002272c0)
gitea[22208]:     /build/go/src/code.gitea.io/gitea/routers/routes/routes.go:142 +0xafe
gitea[22208]: code.gitea.io/gitea/cmd.runWeb(0xc0002272c0, 0x0, 0x0)
gitea[22208]:     /build/go/src/code.gitea.io/gitea/cmd/web.go:125 +0xae
gitea[22208]: code.gitea.io/gitea/vendor/github.com/urfave/cli.HandleAction(0x14af380, 0x172d400, 0xc0002272c0, 0xc000602300, 0x0)
gitea[22208]:     /build/go/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:471 +0xad
gitea[22208]: code.gitea.io/gitea/vendor/github.com/urfave/cli.Command.Run(0x16c0a60, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x16e3ed7, 0x16, 0x0, ...)
gitea[22208]:     /build/go/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/command.go:191 +0x928
gitea[22208]: code.gitea.io/gitea/vendor/github.com/urfave/cli.(*App).Run(0xc000608000, 0xc00000e060, 0x2, 0x2, 0x0, 0x0)
gitea[22208]:     /build/go/src/code.gitea.io/gitea/vendor/github.com/urfave/cli/app.go:241 +0x658
gitea[22208]: main.main()
gitea[22208]:     /build/go/src/code.gitea.io/gitea/main.go:57 +0x426
systemd[1]: gitea.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
systemd[1]: gitea.service: Failed with result 'exit-code'.

The module should probably be changed to not specify [database] → PATH = …, when the database type is not sqlite.

@ajs124 As far as I know, the path setting is simply ignored for everything but sqlite. Notice also that the tests for gitea in NixOS are run for mysql, postgresql and sqlite (and succeeded with this PR.)

This error looks fishy, though: gitea[22208]: panic: default addr for network '/var/lib/gitea/data' unknown

I think this breaks with databases other than sqlite right now, but I'm not 100% sure.

gogs and gitea have always had the promise that "it's just a binary that you run and you don't have to care". Both for running and upgrading. Hence they kinda promise that they will migrate the database as well, otherwise the upgrades wouldn't be smooth as they promise.

I know that we once did an upgrade of gitea in a backport, and one user got upset because it broke because of locales that we copied to the statedir, so with the upgrades the user had the wrong locales. This was fixed in a098cc9 so we put the symlink to the currently running versions locales in the statedir. So the locales won't ever break again on upgrades.

So I think it would be smooth to backport this.

I support a backport as @etu does. It might be worth enabling the dump option by default given how frequently important updates occur. This might save some grief for anyone misguided enough to run gitea without proper backups (what was I thinking?!)...

It might be worth enabling the dump option by default given how frequently important updates occur.

That change would not be backported though... :-)