Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.asyncssh: 1.15.1 -> 1.16.1 #60096

Merged
merged 1 commit into from Apr 24, 2019

Conversation

worldofpeace
Copy link
Contributor

https://github.com/ronf/asyncssh/blob/master/docs/changes.rst#release-1161-30-mar-2019

Motivation for this change

Been waiting forever to pr this 馃ぃ

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

};

patches = [
# Reverts https://github.com/ronf/asyncssh/commit/4b3dec994b3aa821dba4db507030b569c3a32730
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use fetchpatch with revert = true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and it wouldn't apply...

pkgs/development/python-modules/asyncssh/default.nix Outdated Show resolved Hide resolved
@worldofpeace worldofpeace merged commit 76e7783 into NixOS:staging Apr 24, 2019
@worldofpeace worldofpeace deleted the asyncssh-bump branch April 24, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants