New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kde_applications: 18.12.03 -> 19.04.1; kdeFrameworks: 5.56 -> 5.58; plasma-5: 5.15.3 -> 5.15.5 #60035
Conversation
a59ab5a |
@dtzWill thanks I added the patch that I missed |
That's what it does when it can't find it I don't think it's packaged so we'll need to add it. |
Fixed that in the push. Hope you don't mind. |
@worldofpeace ok no problem, I was looking at it too but didn't find how to enable the unit tests |
and as with the previous versions of kdenlive on NixOS there is missing codecs for rendering (only lossless is available) |
Which codecs? At runtime I also saw warnings for missing
|
It's similar to this issue : https://forums.linuxmint.com/viewtopic.php?t=276908 |
The package |
I added qtnetworkauth but |
Eep, sorry!
dtzWill@ca173a3
And not sure what problem you're seeing, I found I needed to disable fb
support w/19.03.90 (19.04rc2?):
(hopefully this was fixed and is not needed!)
dtzWill@7d9d45a
Investigating, sorry! :)
…On Tue, 23 Apr 2019 02:00:47 -0700, Paul TREHIOU ***@***.***> wrote:
I added qtnetworkauth but `kdepim-runtime` is still not compiling (see the PR description)
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#60035 (comment) part: text/html
|
Is there still something blocking the merge ? |
Sorry, I just haven't had a chance to test things @nyanloutre. Have you runtime tested the applications? |
#60889 is a similar patch. It has working kmail. You can cherry pick from there. Notably, it disable facebook from It fixes two compilation errors in diff --git a/agents/archivemailagent/CMakeLists.txt b/agents/archivemailagent/CMakeLists.txt
index 48ed076..9c56896 100644
--- a/agents/archivemailagent/CMakeLists.txt
+++ b/agents/archivemailagent/CMakeLists.txt
@@ -22,6 +22,7 @@ ki18n_wrap_ui(libarchivemailagent_SRCS ui/archivemailwidget.ui )
add_library(archivemailagent STATIC ${libarchivemailagent_SRCS})
target_link_libraries(archivemailagent
KF5::MailCommon
+ KF5::Libkdepim
KF5::I18n
KF5::Notifications
KF5::IconThemes
diff --git a/agents/followupreminderagent/CMakeLists.txt b/agents/followupreminderagent/CMakeLists.txt
index a56b730..83604cf 100644
--- a/agents/followupreminderagent/CMakeLists.txt
+++ b/agents/followupreminderagent/CMakeLists.txt
@@ -23,6 +23,7 @@ target_link_libraries(followupreminderagent
KF5::AkonadiMime
KF5::AkonadiAgentBase
KF5::DBusAddons
+ KF5::FollowupReminder
KF5::XmlGui
KF5::KIOWidgets
KF5::Notifications |
a0ad774
to
f0c0989
Compare
@vandenoever I cherry picked your commits, thanks |
38f7fde
to
f8c5097
Compare
@dtzWill in the kdepim-runtime package was qca-qt5 mandatory for runtime ? (because it's building fine without it) |
nixosTests.plasma5 ran successfully for me |
I would like to abuse this thread a bit. KDE has a yearly conference. It's a great way to let people know how great KDE software works on NixOS and praise the KDE devs in person. If someone feels like presenting a talk along the lines of 'KDE/Plasma on NixOS', I'm sure it would be very much appreciated. https://akademy.kde.org/2019/cfp I try to go every year and it never disappoints. |
I've also built this and done a quick video edit and render with |
@acowley is lossy encoding (x264 for example) working in kdenlive now ? |
It worked out of the box for me (x264 is what I used), but I can’t say why it worked (eg maybe I had ffmpeg available). |
- remove unused qca-qt5
f0a9329
to
11fce46
Compare
Just squashed the fixup commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm inclined to integrate this fairly soon if there isn't any issues raised.
Failures that are new and should be fixed
|
For Krita, it may be this issue: #35359 |
Yes, I'm fairly certain, i.e. it's unrelated to this PR. |
Ok krita build failure is transient, I guess this should be good now. |
Thanks to those involved 🎆 |
Awesome! |
Motivation for this change
Some work will need to be done to make some application work.
Fixed apps:
kdenlive is trying to download https://github.com/rttrorg/rttr during buildkdepim-runtime error:the plasma5 test is passing and every dependencies are cached on https://nyanloutre.cachix.org
any help is welcome
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)