pythonPackages.box2d: fix build by moving swig2 to nativeBuildInputs, remove box2d dependency #59993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
...fix build by moving swig2 to nativeBuildInputs
Looking at the future of this package, the original source appears to be unmaintained, and the pypi entry's homepage is an old broken googlecode.com address.
It's probably worth looking at switching to one of the forks, but which one I'm not particularly sure. I'm not sure how one would gauge the credibility of these sources - https://github.com/pybox2d/pybox2d probably looks the most promising, but then again, anyone can register the "pybox2d" github organization. The bonus from switching upstream would be being able to pull the complete package from github including the tests, which we could then enable.
Edit: Looking at this closer, I realized I was able to remove the
pkgs-box2d
buildInput
entirely. This dependency turns out to be completely unnecessary - the pypi package includes its own bundled copy of the source (I know - ew.) and building withoutpkgs-box2d
results in a binary-identical.so
.This has the side-effect of enabling this package on darwin, which was previously restricted by the apparently linux-only
pkgs-box2d
.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)