Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.box2d: fix build by moving swig2 to nativeBuildInputs, remove box2d dependency #59993

Merged
merged 2 commits into from Apr 27, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 21, 2019

Motivation for this change

...fix build by moving swig2 to nativeBuildInputs

Looking at the future of this package, the original source appears to be unmaintained, and the pypi entry's homepage is an old broken googlecode.com address.

It's probably worth looking at switching to one of the forks, but which one I'm not particularly sure. I'm not sure how one would gauge the credibility of these sources - https://github.com/pybox2d/pybox2d probably looks the most promising, but then again, anyone can register the "pybox2d" github organization. The bonus from switching upstream would be being able to pull the complete package from github including the tests, which we could then enable.

Edit: Looking at this closer, I realized I was able to remove the pkgs-box2d buildInput entirely. This dependency turns out to be completely unnecessary - the pypi package includes its own bundled copy of the source (I know - ew.) and building without pkgs-box2d results in a binary-identical .so.

This has the side-effect of enabling this package on darwin, which was previously restricted by the apparently linux-only pkgs-box2d.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

this dependency turns out to be completely unnecessary - the pypi
package includes its own bundled copy of the source (i know - ew.)
and building without pkgs-box2d results in a binary-identical .so.

this has the side-effect of enabling this package on darwin, which was
previously restricted by the apparently linux-only pkgs-box2d.
@risicle risicle changed the title pythonPackages.box2d: fix build by moving swig2 to nativeBuildInputs pythonPackages.box2d: fix build by moving swig2 to nativeBuildInputs, remove box2d dependency Apr 22, 2019
@FRidh FRidh merged commit d40894c into NixOS:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants