Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: 1.14.2 -> 1.16.0 #60102

Merged
merged 2 commits into from Apr 30, 2019
Merged

nginx: 1.14.2 -> 1.16.0 #60102

merged 2 commits into from Apr 30, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 23, 2019 •
edited

Motivation for this change

Update nginxStable and nginxMainline to 1.16.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2019

@GrahamcOfBorg build nginx
@GrahamcOfBorg test nginx
cc @Mic92

tomberek
tomberek approved these changes Apr 27, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds/runs on Ubuntu. Basic runtime functions look good, but I'd prefer a few more diverse runtime checks by others as well.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

fpletz
fpletz approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to merge to master for testing. We should probably also set nginxMainline to this version since there probably were some fixes for the final stable version.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 30, 2019

Add update nginxMainline to 1.16.0
@GrahamcOfBorg build nginx
@GrahamcOfBorg test nginx

@fpletz
Copy link
Member

fpletz commented Apr 30, 2019

Thanks! 👍

@fpletz fpletz merged commit fe41fdc into NixOS:master Apr 30, 2019
@Izorkin Izorkin deleted the nginxStable branch April 30, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @nixos-discourse @fpletz @tomberek