Remove TinyEnumT type #7538
Merged
Remove TinyEnumT type #7538
+242
−395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
force-pushed
the
tinyenumt-remove
branch
3 times, most recently
from
7b97ffd to
c12d322
Compare
glx22
reviewed
Apr 22, 2019
| STAT_CLASS_BEGIN = 0, ///< the lowest valid value | ||
| STAT_CLASS_DFLT = 0, ///< Default station class. | ||
| STAT_CLASS_WAYP, ///< Waypoint class. | ||
| STAT_CLASS_MAX = 256, ///< Maximum number of classes. | ||
| STAT_CLASS_MAX = 255, ///< Maximum number of classes. |
There was a problem hiding this comment.
This change may need more work because the max value is used as array declaration size in
Line 32 in 66cd32a
OpenTTD/src/newgrf_class_func.h
Line 26 in 66cd32a
Edit: after looking at the newgrf station spec it may be correct.
PeterN
reviewed
Apr 23, 2019
LordAro
force-pushed
the
tinyenumt-remove
branch
from
c12d322 to
4987307
Compare
LordAro
force-pushed
the
tinyenumt-remove
branch
from
4987307 to
130d16f
Compare
PeterN
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.