Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages: fix regression in zarith-dependent libraries #60094

Merged
merged 2 commits into from Apr 25, 2019
Merged

ocamlPackages: fix regression in zarith-dependent libraries #60094

merged 2 commits into from Apr 25, 2019

Conversation

thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Apr 23, 2019 •
edited

Motivation for this change

See #58932 (comment), as well as the explanation in 564653f.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Fits CONTRIBUTING.md.

@thoughtpolice
Revert "ocamlPackages.zarith: 1.7 -> 1.8"
44da3f6 
This reverts commit 1c84236.

See the explanation in 564653f. The
lack of CAML_LD_LIBRARY_PATH causes regressions in dependent downstream
packages that try to use dllzarith.so directly.
@thoughtpolice
ocamlPackages.zarith: 1.7 -> 1.8
1daf31d 
Signed-off-by: Austin Seipp <aseipp@pobox.com>
@thoughtpolice thoughtpolice requested a review from vbgl April 23, 2019 14:24
@thoughtpolice thoughtpolice self-assigned this Apr 23, 2019
@thoughtpolice thoughtpolice added the 0.kind: regression Something that worked before working no longer label Apr 23, 2019
@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.zarith

@thoughtpolice thoughtpolice changed the title Nixpkgs/zarith fixes ocamlPackages: fix regression in zarith-dependent libraries Apr 23, 2019
@vbgl vbgl merged commit ed1b59a into NixOS:master Apr 25, 2019
@vbgl
Copy link
Contributor

vbgl commented Apr 25, 2019

Notice that this breaks zarith on OCaml 4.08.

@thoughtpolice
Copy link
Member Author

Notice that this breaks zarith on OCaml 4.08.

Hmm, I haven't tested this yet (don't have much time this week), but why would that be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

Assignees

@thoughtpolice thoughtpolice

Labels
0.kind: regression Something that worked before working no longer 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @vbgl