New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/packagekit: make it not error out + test #60146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit msg should be
nixos/packagekit: make it not error out
Out of scope of this change, but this has polkit stuff so it probably needs to be in |
c842f69
to
5f18694
Compare
Yikes, wasn't aware of that. We really should have a nicer way to deal with policykit rules than adding them to the global environment. Leaving that out for now as we cannot actually do anything with policykit due to the missing backend, so it doesn't ever need elevated permissions. |
@GrahamcOfBorg test packagekit |
Totally agree on that, definitely something to make issue out of.
Maybe add a |
8de9746
to
d39036e
Compare
Done |
@GrahamcOfBorg test packagekit |
</para> | ||
<para> | ||
On NixOS however, we do not have a backend compatible with nix 2.0 | ||
(refer to https://github.com/NixOS/nix/issues/233) so we have to force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should use a link like <link xlink:href="https://theissue">Some words</link>
type = types.enum [ "test_nop" ]; | ||
default = "test_nop"; | ||
description = '' | ||
PackageKit supports multiple different backends and `auto` which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackageKit supports multiple different backends and `auto` which | |
PackageKit supports multiple different backends and <literal>auto</literal> which |
@worldofpeace all your comments have been addressed. |
Thank you for fixing this @peterhoeg |
Motivation for this change
We have a nixos module for packagekit, but it doesn't work as we do not have a backend for nix (#21230) so we now make the backend configurable and set it to
test_nop
which at least means that other software depending on packagekit (#34756 needs it) will at least not error out complaining about not being able to connect to to packagekit over dbus.Cc: @peti @matthewbauer @wizeman
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)