Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/openldap: make rootpw option optional #60097

Merged
merged 1 commit into from May 1, 2019
Merged

nixos/openldap: make rootpw option optional #60097

merged 1 commit into from May 1, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 23, 2019 •
edited

This allows to store passwords in external files outside of the world-readable
nix store.

cc @ciil

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/openldap: make rootpw option optional
d43dc68 
This allows to store passwords in external files outside of the world-readable
nix store.
@Mic92 Mic92 requested a review from infinisil as a code owner April 23, 2019 15:36
@Mic92
Copy link
Member Author

Mic92 commented Apr 23, 2019

@GrahamcOfBorg test openldap

ciil
ciil approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@ciil ciil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable and useful.

@infinisil infinisil merged commit c68124b into NixOS:master May 1, 2019
@Mic92 Mic92 deleted the openldap-rootpw-file branch May 2, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciil ciil ciil approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @ciil @infinisil