Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup: 1.17.0 -> 1.18.1 #60098

Merged
merged 1 commit into from Apr 27, 2019
Merged

rustup: 1.17.0 -> 1.18.1 #60098

merged 1 commit into from Apr 27, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 23, 2019 •
edited

Motivation for this change

Update rustup to the latest release.
https://github.com/rust-lang/rustup.rs/releases/tag/1.18.1
Changes: https://github.com/rust-lang/rustup.rs/blob/1.18.1/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 April 23, 2019 16:01
@sondr3
Copy link
Contributor

sondr3 commented Apr 23, 2019

We could probably automatically generate shell completion when installing Rustup from this PR.

@xrelkd xrelkd changed the title rustup: 1.17.0 -> 1.18.0 rustup: 1.17.0 -> 1.18.1 Apr 25, 2019
@Mic92 Mic92 merged commit a784e28 into NixOS:master Apr 27, 2019
@xrelkd xrelkd deleted the update/rustup branch April 27, 2019 10:15
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 27, 2019

@sondr3 @Mic92 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @sondr3 @Mic92