Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettext: fix cross build #60123

Merged
merged 1 commit into from Apr 23, 2019
Merged

gettext: fix cross build #60123

merged 1 commit into from Apr 23, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Fixes the cross build of gettext that was broken by the incorrect use of optional in #59553.

Things done

cc @strager @veprbl

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl merged commit 16fe069 into NixOS:master Apr 23, 2019
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 23, 2019
@veprbl veprbl self-assigned this Apr 23, 2019
@lopsided98 lopsided98 deleted the gettext-cross-fix branch April 23, 2019 22:42
veprbl pushed a commit that referenced this pull request Apr 24, 2019
@lopsided98 @veprbl
gettext: fix cross build (#60123)
9fe75cc 
(cherry picked from commit 16fe069)
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 24, 2019
@veprbl veprbl removed their assignment Apr 24, 2019
@marsam marsam mentioned this pull request May 21, 2019
Merged
10 tasks
@marsam marsam mentioned this pull request Nov 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @marsam @veprbl