Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromaprint: 1.3.2 -> 1.4.3 #60137

Closed
wants to merge 2 commits into from
Closed

chromaprint: 1.3.2 -> 1.4.3 #60137

wants to merge 2 commits into from

Conversation

hhm0
Copy link
Contributor

@hhm0 hhm0 commented Apr 24, 2019

Motivation for this change

B"H

This pull updates chromaprint, and applies a patch to clementine so it builds with the newer chromaprint.

See https://github.com/acoustid/chromaprint/releases/tag/v1.4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented May 5, 2019

@GrahamcOfBorg build chromaprint

@hhm0 hhm0 mentioned this pull request Aug 14, 2019
Closed
@samdoshi samdoshi mentioned this pull request Oct 9, 2019
Closed
10 tasks
@samdoshi
Copy link
Contributor

samdoshi commented Oct 9, 2019

@hhm0 are you able to rebase this PR?

The current version of Picard doesn't work with fpcalc from chromaprint 1.3.2. It would be nice to be able to get this merged.

This was referenced Oct 9, 2019
Merged
Merged
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 18, 2019

Superseded by #70658

@c0bw3b c0bw3b closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hhm0 @marsam @samdoshi @c0bw3b