wireguard: add generatePrivateKeyFile option + test #60138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test wireguard |
grahamc
force-pushed
the
wireguard-generate-key
branch
from
f6c6c62
to
7b7ba23
Compare
grahamc
commented
Apr 24, 2019
| @@ -282,7 +333,12 @@ in | |||
| boot.extraModulePackages = [ kernel.wireguard ]; | |||
| environment.systemPackages = [ pkgs.wireguard-tools ]; | |||
|
|
|||
| systemd.services = mapAttrs' generateUnit cfg.interfaces; | |||
| systemd.services = (x: builtins.trace x x) ((mapAttrs' generateSetupServiceUnit cfg.interfaces) | |||
|
Plus some nice assertion improvements based on feedback from @infinisil! |
grahamc
force-pushed
the
wireguard-generate-key
branch
from
d668f61
to
e1d15a4
Compare
Ma27
reviewed
Apr 24, 2019
Ideally, private keys never leave the host they're generated on - like SSH. Setting generatePrivateKeyFile to true causes the PK to be generate automatically.
|
Seems this PR is good then, @Ma27 ? |
grahamc
force-pushed
the
wireguard-generate-key
branch
from
e1d15a4
to
06c83a1
Compare
Ma27
approved these changes
Apr 24, 2019
|
@grahamc thanks! |
|
Thank you! |
nh2
reviewed
Apr 30, 2021
| mkdir --mode 0644 -p "${dirOf values.privateKeyFile}" | ||
| if [ ! -f "${values.privateKeyFile}" ]; then | ||
| touch "${values.privateKeyFile}" | ||
| chmod 0600 "${values.privateKeyFile}" |
There was a problem hiding this comment.
This is not safe.
The private key can be read by an unprivileged user who opens the file between touch and chmod.
touch + chmod 600 + write are never safe. This is why install --mode (like mkdir --mode) and umask exist. See for example the key generation section in ArchWiki or NixOS's wiki.
puppe
added a commit
to puppe/secrets
that referenced
this pull request
Oct 1, 2021
Apparently it is not safe to first create a file with touch and then set permissions with chmod. An unprivileged user could open the file in between. See NixOS/nixpkgs#60138 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, private keys never leave the host they're generated on - like
SSH. Setting generatePrivateKeyFile to true causes the PK to be
generate automatically.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)