Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxvt_unicode: fix build #60139

Merged
merged 1 commit into from Apr 24, 2019
Merged

rxvt_unicode: fix build #60139

merged 1 commit into from Apr 24, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Apr 24, 2019

Motivation for this change

Fixes a last-minute change introduced in #59896 that broke the rxvt package:

> :b pkgs.rxvt_unicode-with-plugins
builder for '/nix/store/a41snhm28vmqqgxnwbc9645cn403y6ng-rxvt-unicode-with-perl-with-unicode3-with-plugins-9.22.drv' failed with exit code 1; last 9 log lines:
  
  Builder called die: makeWrapper doesn't understand the arg 
  Backtrace:
  108 makeWrapper /nix/store/2j5wxs045w8svy2494hh1p8y1d3ah8ak-hook/nix-support/setup-hook
  152 wrapProgram /nix/store/2j5wxs045w8svy2494hh1p8y1d3ah8ak-hook/nix-support/setup-hook
  5 source /build/.attr-0
  1273 genericBuild /nix/store/jqavib0kpn83cp0gjcq9pw8bvfas1kc0-stdenv-linux/setup
  2 main /nix/store/9krlzvny65gdc8s7kpb6lkx8cd02c25b-default-builder.sh
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @rnhmjoj @joachifm

@joachifm joachifm merged commit 8f33fb5 into NixOS:master Apr 24, 2019
@arcnmx arcnmx deleted the rxvt-build-fix branch April 24, 2019 03:13
@joachifm
Copy link
Contributor

Oops. I failed to notice that the change was not actually what I had suggested. My bad. Thank you.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 24, 2019

Thank you

@jimstutt
Copy link

jimstutt commented Aug 1, 2019

nix-env -aqP rxvt_unicode
error: selector 'rxvt_unicode' matches no derivations.
nix-env -aqP rxvt-unicode
error: selector 'rxvt-unicode' matches no derivations.
nixos: 19.03
'channel: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants