Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcl/tk: 8.6.6 -> 8.6.9 #60063

Merged
merged 1 commit into from Apr 27, 2019
Merged

tcl/tk: 8.6.6 -> 8.6.9 #60063

merged 1 commit into from Apr 27, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Apr 22, 2019

Changelog for Tcl: https://github.com/tcltk/tcl/blob/core-8-6-9/changes#L8797
Changelog for Tk: https://github.com/tcltk/tk/blob/master/changes#L7417
Tk release is actually v8.6.9.1 while Tcl is v8.6.9

Motivation for this change

Version bumps
Follow-up to #35069

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
tcl/tk: 8.6.6 -> 8.6.9
68e56c4 
Changelog for Tcl: https://github.com/tcltk/tcl/blob/core-8-6-9/changes#L8797
Changelog for Tk: https://github.com/tcltk/tk/blob/master/changes#L7417

Tk release is actually v8.6.9.1 while Tcl is v8.6.9
@ofborg ofborg bot requested review from vrthra and lovek323 April 22, 2019 22:00
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Apr 22, 2019

I'm not sure why so many rebuilds on Linux .. ❔ (compared to that older PR)
I'm running a partial nix-review locally right now and it's rebuilding llvm :/

@samueldr samueldr mentioned this pull request Apr 22, 2019
Closed
10 tasks
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Apr 23, 2019

Locally I built tcl tk gitAndTools.gitFull scid-vs-pc on NixOS 19.03 without issue.
The tkscid chess game runs fine using Tk v8.6.9

@FRidh FRidh merged commit 3ee1b52 into NixOS:staging Apr 27, 2019
@c0bw3b c0bw3b deleted the pkg/tcl-tk branch April 27, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @FRidh