Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs: 0.4.19 -> 0.4.20 #60148

Merged
merged 1 commit into from Apr 27, 2019
Merged

ipfs: 0.4.19 -> 0.4.20 #60148

merged 1 commit into from Apr 27, 2019

Conversation

elitak
Copy link
Contributor

@elitak elitak commented Apr 24, 2019 •
edited

Motivation for this change
Things done

The upstream repo no longer uses gx, so I had to generate a deps.nix using vgo2nix, and hand-add 1 broken entry to it.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c00w
c00w approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@c00w c00w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good - I think one line is unneeded

  • Ran nix-review pr 60148, ipfs builds, seems to run, add file, fetch file successfully.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/22

@srhb
Copy link
Contributor

srhb commented Apr 26, 2019

@GrahamcOfBorg build ipfs

@srhb srhb merged commit fabe630 into NixOS:master Apr 27, 2019
@elitak elitak deleted the ipfs-bump branch April 28, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c00w c00w c00w approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elitak @nixos-discourse @srhb @c00w