qt 5.12.0 -> 5.12.3 WIP #60119

vandenoever · 2019-04-23T19:15:16Z

Motivation for this change

Qt 5.12 has received 3 bugfix releases since 5.12.0. However updating it has proven non-trivial. This PR is a WIP.

Things done

vandenoever · 2019-04-23T19:15:55Z

See also #57042

ttuegel · 2019-04-27T18:21:37Z

Does the configure script produce a log file, so we could see what compilation tests it's doing?

vandenoever · 2019-04-27T20:06:24Z

Yes there was.

config.log

The first FAILED is about not finding zlib:

None of [libz.so libz.a] found in [] and global paths.

vandenoever · 2019-05-05T12:37:49Z

qtbase compiles in the latest version of this patch.

vandenoever · 2019-05-06T06:15:30Z

The current patch compiles, but does not work with X11: a KDE system with it does not start the graphical login sddm.

This is the configuration report of Qt 5.12.0 next to that of Qt 5.12.3:

Qt Gui:                                                         Qt Gui:
  Accessibility .......................... yes                    Accessibility .......................... yes
  FreeType ............................... yes                    FreeType ............................... yes
    Using system FreeType ................ yes                      Using system FreeType ................ yes
  HarfBuzz ............................... yes                    HarfBuzz ............................... yes
    Using system HarfBuzz ................ yes                      Using system HarfBuzz ................ yes
  Fontconfig ............................. yes                    Fontconfig ............................. yes
  Image formats:                                                  Image formats:
    GIF .................................. yes                      GIF .................................. yes
    ICO .................................. yes                      ICO .................................. yes
    JPEG ................................. yes                      JPEG ................................. yes
      Using system libjpeg ............... yes                        Using system libjpeg ............... yes
    PNG .................................. yes                      PNG .................................. yes
      Using system libpng ................ yes                        Using system libpng ................ yes
  EGL .................................... yes                    EGL .................................... yes
  OpenVG ................................. no                     OpenVG ................................. no
  OpenGL:                                                         OpenGL:
    Desktop OpenGL ....................... yes                      Desktop OpenGL ....................... yes
    OpenGL ES 2.0 ........................ no                       OpenGL ES 2.0 ........................ no
    OpenGL ES 3.0 ........................ no                       OpenGL ES 3.0 ........................ no
    OpenGL ES 3.1 ........................ no                       OpenGL ES 3.1 ........................ no
    OpenGL ES 3.2 ........................ no                       OpenGL ES 3.2 ........................ no
  Vulkan ................................. no                     Vulkan ................................. no
  Session Management ..................... yes                    Session Management ..................... yes
Features used by QPA backends:                                  Features used by QPA backends:
  evdev .................................. yes                    evdev .................................. yes
  libinput ............................... yes                    libinput ............................... yes
  INTEGRITY HID .......................... no                     INTEGRITY HID .......................... no
  mtdev .................................. no                     mtdev .................................. no
  tslib .................................. no                     tslib .................................. no
  xkbcommon-evdev ........................ yes                |   xkbcommon .............................. yes
                                                              >   X11 specific:
                                                              >     XLib ................................. no
                                                              >     XCB Xlib ............................. no
                                                              >     EGL on X11 ........................... no
QPA backends:                                                   QPA backends:
  DirectFB ............................... no                     DirectFB ............................... no
  EGLFS .................................. no                     EGLFS .................................. no
  LinuxFB ................................ no                     LinuxFB ................................ no
  VNC .................................... yes                    VNC .................................... yes
  Mir client ............................. no                     Mir client ............................. no
  X11:                                                        |   XCB:
    Using system-provided XCB libraries .. yes                      Using system-provided XCB libraries .. yes
    EGL on X11 ........................... yes                <
    XCB XKB .............................. yes                      XCB XKB .............................. yes
    XLib ................................. yes                <
    XCB render ........................... yes                <
    XCB GLX .............................. yes                <
    XCB XInput ........................... yes                      XCB XInput ........................... yes
    XCB Xlib ............................. yes                |     Native painting (experimental) ....... no
    Using system-provided xkbcommon ...... yes                |     GL integrations:
    Native painting (experimental) ....... yes                |       GLX Plugin ......................... no
                                                              >       EGL-X11 Plugin ..................... no

The GLX Plugin and EGL-X11 Plugin are missing, as is the XLib detection.

vandenoever · 2019-05-06T06:48:38Z

The current version of the patch detects X properly. All the features detected in Qt 5.12.0 are also detected in Qt 5.12.3.

Testing will be done once the patched version and KDE software has compiled.

vandenoever · 2019-05-06T21:48:43Z

I'm running my desktop now with Qt 5.12.3 (this patch) and the latest KDE software on NixOS 19.03.

Everything works except the global KWin shortcuts (Alt-Tab, Ctrl-F1 etc). Other global shortcut like Alt-Space / Alt-F2, Meta-P still work. I'm not sure this is related to this patch.

vandenoever · 2019-05-06T23:13:51Z

After rebooting the machine the global kwin shortcuts work again. In fact, the bug that I hoped would be fixed by upgrading from Qt 5.12.0 to Qt 5.12.3 is gone. https://bugs.kde.org/show_bug.cgi?id=406829

dtzWill · 2019-05-07T00:34:59Z

On Mon, 06 May 2019 16:13:59 -0700, Jos van den Oever ***@***.***> wrote: After rebooting the machine the global kwin shortcuts work again. In fact, the bug that I hoped would be fixed by upgrading from Qt 5.12.0 to Qt 5.12.3 is gone. https://bugs.kde.org/show_bug.cgi?id=406829

I don't run KDE, but use lots of qt-based/kde software -- and so far this is working great here as well! <3

…

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #60119 (comment) part: text/html

eadwu · 2019-05-26T20:34:30Z

pkgs/top-level/all-packages.nix

@@ -12717,7 +12717,7 @@ in
      inherit stdenv fetchurl fetchFromGitHub makeSetupHook;
      bison = bison2; # error: too few arguments to function 'int yylex(...
      inherit cups;
-      harfbuzz = harfbuzzFull;
+      inherit harfbuzz;


This should be under qt512 in order for qtbase to pass configurePhase.

eadwu · 2019-05-27T00:48:42Z

Builds fine in sandbox on x86_64. Everything I use looks more or less the same with the upgrade while what was broken with 5.12.0 is still broken for me.

vandenoever · 2019-06-18T20:58:37Z

In the meantime qt 5.12.4 has been released.

dtzWill · 2019-06-20T00:53:43Z

5.12.4 seems close to 5.12.3, but I'm having trouble "sanely" forward-porting the qtbase-related patches-- mostly I'm at the point of essentially rewriting them from scratch (so that I understand the pieces, how they've changed, and how we may want them to work in NixOS-land). Unfortunately I am not up to this task for the coming weeks (months) most likely, but maybe others find better success with the changes (this is where my hope lies :)). I don't think it's too hairy, but may require better quickfix-fu or some degree of deep-diving. It's possible 5.12.4 moves things more towards our preferred situation... that I can't tell is why I'm writing this comment and calling it quits for a bit O:).

dtzWill · 2019-06-20T01:00:46Z

I'm not sure we would be able to move to it piecemeal, but notably qt 5.12.4 supports openssl 1.1 which might motivate sorting these things out eventually :).

ttuegel

This looks good to me! We can worry about Qt 5.12.4 later. I'm not going to "approve" because this should go into staging; @vandenoever would you mind opening a new pull request? Sorry 🙁

FRidh · 2019-07-11T07:38:31Z

Closing in favor of #64598

vandenoever requested a review from ttuegel as a code owner April 23, 2019 19:15

vandenoever mentioned this pull request Apr 23, 2019

Qt: update to 5.12.3 #57042

Closed

ofborg bot added the 6.topic: qt/kde label Apr 23, 2019

ofborg bot requested review from periklis and qknight April 23, 2019 19:28

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 labels Apr 23, 2019

vandenoever mentioned this pull request May 3, 2019

KDE / Plasma updates #60889

Closed

9 tasks

vandenoever force-pushed the qt branch from 8bf128e to a608eee Compare May 5, 2019 12:12

ofborg bot added 10.rebuild-darwin: 101-500 and removed 10.rebuild-darwin: 11-100 labels May 5, 2019

vandenoever force-pushed the qt branch from a608eee to 707ddab Compare May 5, 2019 15:45

vandenoever force-pushed the qt branch from 707ddab to d1310ba Compare May 6, 2019 06:46

vandenoever force-pushed the qt branch from d1310ba to a5e3470 Compare May 26, 2019 14:43

eadwu suggested changes May 26, 2019

View reviewed changes

qt 5.12.0 -> 5.12.3

a45a32b

vandenoever force-pushed the qt branch from a5e3470 to a45a32b Compare May 26, 2019 20:44

ttuegel reviewed Jun 27, 2019

View reviewed changes

This was referenced Jul 10, 2019

qt5.12 base: Add patch to fix QTBUG-73459 #63775

Closed

Qt 5.12.3 #64598

Merged

FRidh changed the base branch from master to staging July 11, 2019 07:38

FRidh closed this Jul 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qt 5.12.0 -> 5.12.3 WIP #60119

qt 5.12.0 -> 5.12.3 WIP #60119

vandenoever commented Apr 23, 2019 •

edited

vandenoever commented Apr 23, 2019

ttuegel commented Apr 27, 2019

vandenoever commented Apr 27, 2019 •

edited

vandenoever commented May 5, 2019

vandenoever commented May 6, 2019

vandenoever commented May 6, 2019

vandenoever commented May 6, 2019

vandenoever commented May 6, 2019

dtzWill commented May 7, 2019 via email

eadwu May 26, 2019

vandenoever May 26, 2019

eadwu commented May 27, 2019

vandenoever commented Jun 18, 2019

dtzWill commented Jun 20, 2019

dtzWill commented Jun 20, 2019

ttuegel left a comment

FRidh commented Jul 11, 2019

qt 5.12.0 -> 5.12.3 WIP #60119

qt 5.12.0 -> 5.12.3 WIP #60119

Conversation

vandenoever commented Apr 23, 2019 • edited

Motivation for this change

Things done

vandenoever commented Apr 23, 2019

ttuegel commented Apr 27, 2019

vandenoever commented Apr 27, 2019 • edited

vandenoever commented May 5, 2019

vandenoever commented May 6, 2019

vandenoever commented May 6, 2019

vandenoever commented May 6, 2019

vandenoever commented May 6, 2019

dtzWill commented May 7, 2019 via email

eadwu May 26, 2019

Choose a reason for hiding this comment

vandenoever May 26, 2019

Choose a reason for hiding this comment

eadwu commented May 27, 2019

vandenoever commented Jun 18, 2019

dtzWill commented Jun 20, 2019

dtzWill commented Jun 20, 2019

ttuegel left a comment

Choose a reason for hiding this comment

FRidh commented Jul 11, 2019

vandenoever commented Apr 23, 2019 •

edited

vandenoever commented Apr 27, 2019 •

edited