Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia_x11_beta: stable -> 430.09 #60121

Merged
merged 1 commit into from May 3, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 23, 2019

Haven't got a clue why the links were changed for the downloads now. nvidia-settings and nvidia-persistenced are just retrieved from github now since the beta doesn't seem to have it. Beta compiles fine on 5.1.0-rc6.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Apr 23, 2019

cc @baracoder

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and booted on 5.1.0-rc6. Thanks!

@@ -41,7 +41,10 @@ let
src =
if stdenv.hostPlatform.system == "x86_64-linux" then
fetchurl {
url = "https://download.nvidia.com/XFree86/Linux-x86_64/${version}/NVIDIA-Linux-x86_64-${version}${pkgSuffix}.run";
urls = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change affects all versions, did you check if older versions still build? If not please try e.g.

nix-build . -A linuxPackages_4_14.nvidia_x11_legacy340

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that this wouldn't change much since according to https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchurl/default.nix#L41 the original is still tried first.

Anyway legacy_304 fails due to other reasons.

~ took 2s
➜  nix build --no-link nixpkgs.linuxPackages_latest.nvidiaPackages.stable_418 nixpkgs.linuxPackages_latest.nvidiaPackages.legacy_390 nixpkgs.linuxPackages.nvidiaPackages.legacy_340 nixpkgs.linuxPackages_4_14.nvidiaPackages.legacy_304
builder for '/nix/store/wpgja6m5g4y1y0x4g0an3fbsbr7gcyjd-nvidia-graphics-drivers-legacy-304xx_304.137-5.debian.tar.xz.drv' failed with exit code 1; last 10 log lines:
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found

  trying ftp://ftp.funet.fi/pub/mirrors/ftp.debian.org/debian/pool/non-free/n/nvidia-graphics-drivers-legacy-304xx/nvidia-graphics-drivers-legacy-304xx_304.137-5.debian.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0
  curl: (78) RETR response: 550
  error: cannot download nvidia-graphics-drivers-legacy-304xx_304.137-5.debian.tar.xz from any mirror
cannot build derivation '/nix/store/ba09405sk0mib67b0c3x2skzypzmyzl3-nvidia-x11-304.137-4.14.113.drv': 1 dependencies couldn't be built
[4 built (1 failed), 2 copied (152.2 MiB), 67.8 MiB DL]
error: build of '/nix/store/ba09405sk0mib67b0c3x2skzypzmyzl3-nvidia-x11-304.137-4.14.113.drv', '/nix/store/c0qywjagm96in1srh2mbfadhyxmbpdib-nvidia-x11-390.116-5.0.9.drv', '/nix/store/dkyk3iz03qi8wz9dqr3k9i20p9rd7vfs-nvidia-x11-340.107-4.19.36.drv', '/nix/store/qvbmgjjnr3v5zs6yiby5bbs8kaw7wac1-nvidia-x11-418.56-5.0.9.drv' failed

~ took 43s
➜  nix build --no-link nixpkgs.linuxPackages_latest.nvidiaPackages.stable_418 nixpkgs.linuxPackages_latest.nvidiaPackages.legacy_390 nixpkgs.linuxPackages.nvidiaPackages.legacy_340
[3 built]

@thoughtpolice
Copy link
Member

Merging this since it's an annoying nit while I'm working with _testing. I've confirmed some older packages (e.g. 4_14.nvidia_x11_legacy390) still work fine, so let's go ahead and merge; if there are issues, let's work it out!

@thoughtpolice thoughtpolice merged commit f60936d into NixOS:master May 3, 2019
@eadwu eadwu deleted the nvidia_x11_beta/430.09 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants