Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kreport: 3.1.0 -> 3.2.0 #60047

Closed
wants to merge 1 commit into from
Closed

kreport: 3.1.0 -> 3.2.0 #60047

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Apr 23, 2019

Are we able to switch to qtwebengine now? #53079

@dtzWill
Copy link
Member Author

dtzWill commented Apr 24, 2019 via email

@dtzWill dtzWill mentioned this pull request Apr 26, 2019
Merged
10 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

Folding into #60050 .

@dtzWill dtzWill closed this Apr 26, 2019
@dtzWill dtzWill deleted the update/kreport-3.2.0 branch April 26, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @veprbl @GrahamcOfBorg