Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kproperty,kreport,kexi: 3.1.0 -> 3.2.0 #60050

Merged
merged 4 commits into from Apr 28, 2019
Merged

kproperty,kreport,kexi: 3.1.0 -> 3.2.0 #60050

merged 4 commits into from Apr 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Apr 26, 2019
Merged
@JohnAZoidberg
Copy link
Member

Does it build for you?
I get:

CMake Error at CMakeLists.txt:159 (find_package):
  Could not find a configuration file for package "KDb" that is compatible
  with requested version "3.1.91".

  The following configuration files were considered but not accepted:

    /nix/store/c1k1ajs9r720wn0r7gd2v0ynlp7zcfbw-kdb-3.1.0/lib/cmake/KDb3/KDbConfig.cmake, version: 3.1.0

@JohnAZoidberg
Copy link
Member

Still failing, even after the other upgrade :P

  Could not find a configuration file for package "KReport" that is
  compatible with requested version "3.1.91".

  The following configuration files were considered but not accepted:

    /nix/store/jaz8ph7hl24v7gsl8gvdqnavkzram7h1-kreport-3.1.0/lib/cmake/KReport3/KReportConfig.cmake, version: 3.1.0



CMake Error at CMakeLists.txt:179 (find_package):
  Could not find a configuration file for package "KPropertyWidgets" that is
  compatible with requested version "3.1.91".

  The following configuration files were considered but not accepted:

    /nix/store/j0l85n15kpj3dgdq9l6jpw5bm6zc60qi-kproperty-3.1.0/lib/cmake/KPropertyWidgets3/KPropertyWidgetsConfig.cmake, version: 3.1.0

@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

D'oh, sorry i tested mostly with the entire upgrade stack and split for PR's.

From the posted log, looks like also needs #60047 and #60048 ?

@JohnAZoidberg
Copy link
Member

Yeah, looks like it.
Hmm, if they're all that interdependent would upgrading these packages break other packages?

@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

Hmm, don't think so re:breakage-- quick grep suggests kreport and kproperty are only used in calligra (long since broken) and this package, kexi. So maybe they should be all upgraded together, yes! :).

@dtzWill dtzWill changed the title kexi: 3.1.0 -> 3.2.0 kproperty,kreport,kexi: 3.1.0 -> 3.2.0 Apr 26, 2019
This was referenced Apr 26, 2019
Closed
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Apr 26, 2019

@GrahamcOfBorg kexi

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Apr 26, 2019 •
edited

nix-review says it's fine now :)
Builds fine but can't find the breeze-icons when I try to run it and subsequently exits with an error message.
I think #54525 would fix that.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 28, 2019

Agreed, runs fine here. Thanks for testing!

@dtzWill dtzWill merged commit 7546396 into NixOS:master Apr 28, 2019
@dtzWill dtzWill deleted the update/kexi-3.2.0 branch April 28, 2019 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @JohnAZoidberg