Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome 3.32.1 staging updates #60056

Merged
merged 3 commits into from Apr 27, 2019
Merged

gnome 3.32.1 staging updates #60056

merged 3 commits into from Apr 27, 2019

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 22, 2019

Motivation for this change

Some gnome 3.32.1 updates for staging:
https://gitlab.gnome.org/GNOME/glib/blob/2.60.1/NEWS
https://gitlab.gnome.org/GNOME/libsoup/blob/2.66.1/NEWS
https://gitlab.gnome.org/GNOME/libcroco/blob/0.6.13/NEWS

Should probably be merged together with #59406

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

Have you checked if Aarch64 failure is relevant?

@hedning
Copy link
Contributor Author

hedning commented Apr 22, 2019

Looks like it's a dependency of mesa-noglu (probably pythonPackages.Mako, though the log isn't all that clear) that fails which then propagates to libsoup through gobject-introspection. mesa-noglu doesn't itself depend on glib so should be unrelated.

I based the commits on staging and master's merge base so could easily switch to master to check the builds there if that's wanted.

@7c6f434c
Copy link
Member

Ah. builder for '/nix/store/rwnkwwsgmdyn1giz30w5dm5jvr08wdwy-libuv-1.27.0.drv' failed with exit code 2

@FRidh FRidh merged commit ee37299 into NixOS:staging Apr 27, 2019
@hedning hedning deleted the gnome-3.32-staging branch October 15, 2019 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hedning @7c6f434c @FRidh @GrahamcOfBorg