Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpa_supplicant: 2.7 -> 2.8 #60055

Merged
merged 2 commits into from Apr 26, 2019
Merged

wpa_supplicant: 2.7 -> 2.8 #60055

merged 2 commits into from Apr 26, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 22, 2019

Motivation for this change

Testing with your wireless card appreciated!

I've been using iwd :3 but will give this a go later--
regardless it'd be good to avoid breaking too many folks' wireless! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Apr 22, 2019

cc #60053

@worldofpeace
Copy link
Contributor

Runtime testing this currently. Looks good so far (even resolved some issues).

@hedning hedning added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 23, 2019
@hedning
Copy link
Contributor

hedning commented Apr 23, 2019

Should probably be backported: #60117

primeos
primeos approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing with your wireless card appreciated!

Works on my system (Dell XPS 13 with Qualcomm Atheros QCA6174) :)
I've tested it on a WPA2-Personal and WPA2-Enterprise network and wpa_cli still works as well.

@worldofpeace
Copy link
Contributor

change for 19.03 for the vulnerabilities btw #60143

@worldofpeace worldofpeace merged commit fcb0aa8 into NixOS:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@primeos primeos primeos approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @worldofpeace @hedning @NeQuissimus @primeos @GrahamcOfBorg