Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrooge: 2.18.0 -> 2.19.1 #60046

Merged
merged 2 commits into from
Apr 28, 2019
Merged

skrooge: 2.18.0 -> 2.19.1 #60046

merged 2 commits into from
Apr 28, 2019
+2 −2

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 22, 2019

Motivation for this change

https://skrooge.org/node/236

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg requested a review from jokogr April 22, 2019 21:02
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 22, 2019
@dtzWill dtzWill changed the title skrooge: 2.18.0 -> 2.19.0 skrooge: 2.18.0 -> 2.19.1 Apr 28, 2019
@dtzWill dtzWill merged commit 1f0d362 into NixOS:master Apr 28, 2019
@dtzWill dtzWill deleted the update/skrooge-2.19.0 branch April 28, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokogr jokogr

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg