Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildRustCrate: Fix #60125 - Always set additional env variables during build #60127

Merged
merged 1 commit into from Apr 24, 2019

Conversation

kolloch
Copy link
Contributor

@kolloch kolloch commented Apr 23, 2019

Namely CARGO_PKG_VERSION_PRE and CARGO_PKG_HOMEPAGE
(as cargo does)

@P-E-Meunier

Motivation for this change

The built crate assumes that these environment variables are always set at build time. Cargo does that. Since we are emulating cargo, we should, too.

Things done

I build the crate that failed before using the update nixpkgs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@P-E-Meunier
Copy link
Contributor

Looks good to me. I just updated the master branch of Carnix, this should be included in the next version.

@dywedir
Copy link
Member

dywedir commented Apr 24, 2019

Thanks!

@dywedir dywedir merged commit 0e6ae0b into NixOS:master Apr 24, 2019
kolloch added a commit to nix-community/crate2nix that referenced this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants