Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xv: init at 0.1.0 #60128

Merged
merged 1 commit into from Apr 24, 2019
Merged

xv: init at 0.1.0 #60128

merged 1 commit into from Apr 24, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Apr 23, 2019 •
edited

Motivation for this change

New tool xv: https://chrisvest.github.io/xv/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Linux in Docker)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Running the Linux build in Docker didn't print the unicode characters correctly, but I'm assuming that's some artifact of the Docker environment. I tested on NixOS and it works properly there.

@thoughtpolice
Copy link
Member

Thanks a bunch!

@thoughtpolice thoughtpolice merged commit 6088a47 into NixOS:master Apr 24, 2019
@lilyball lilyball deleted the xv branch April 24, 2019 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @thoughtpolice @JohnAZoidberg