Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-12_x: init at 12.0.0 #60130

Merged
merged 2 commits into from Apr 26, 2019
Merged

nodejs-12_x: init at 12.0.0 #60130

merged 2 commits into from Apr 26, 2019

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Apr 23, 2019

Motivation for this change

Release Notes

Things done

nodejs 12 requires libuv 1.28.0 that’s why I’ve updated libuv in this PR as well.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from andir, cstrahan and lovek323 April 23, 2019 23:14
@dtzWill
Copy link
Member

dtzWill commented Apr 26, 2019

LGTM, including libuv update!

@dtzWill dtzWill merged commit 5340c05 into NixOS:staging Apr 26, 2019
@lo1tuma lo1tuma deleted the nodejs-12_staging branch April 26, 2019 06:27
@marsam marsam mentioned this pull request Apr 26, 2019
Closed
@angristan angristan mentioned this pull request Apr 29, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@cstrahan cstrahan Awaiting requested review from cstrahan

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lo1tuma @dtzWill