networkmanager: 1.16.0 -> 1.18.0 #60060
Conversation
|
Also we need to keep |
|
Technically conflicts, but I think it'll be more or less the same before or after. But might be best to be sure to handle the conflict in the same branch and not burden someone merging staging to master or something :). |
|
Unless there's a strong reason to go the other way 'round (LMK!), I'm happy with (and suggest) we tackle the meson conversion first. One thing at a time! :) |
|
(or include this in the conversion? Whatever y'all feel is best ^_^) |
|
Enjoyed reading your comments as they came in because we were thinking all the same things 🤣 Not sure how to go about things, probably path of least resistance 👍 |
|
From the changelog |
* build w/iwd support since it's free (no dep required!) * move to iputils for minor utilities, instead of inetutils * parallel building :) https://gitlab.freedesktop.org/NetworkManager/NetworkManager/raw/1.18.0/NEWS
dtzWill
force-pushed
the
update/networkmanager-1.18
branch
from
19fb038
to
b053777
Compare
|
Rebased onto staging, which now has the meson conversion.
Still working on rebuild-all-the-things to test,
but it was straightforward so hopefully works well too :).
|
|
On Mon, 22 Apr 2019 20:56:51 -0700, Wael Nasreddine ***@***.***> wrote:
kalbasit commented on this pull request.
> @@ -63,4 +65,3 @@
g_ptr_array_add (argv, "--use-blacklist");
g_ptr_array_add (argv, (char *) arg1);
- va_start (ap, arg1);
is this an accidental removal?
Yes and no :).
I did not set out to remove this, and I'm not sure I'm aware it was
removed.
Even so, it wasn't quite "accidental" in that AFAICT it was simply
determined not useful when I generated the patch :).
Perhaps different settings were used previously, but it applies
so I'm inclined to think it's alright.
The next line is still the same, however, so I think if you'd prefer
we can touchup the patch to keep it.
…
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#60060 (review) part: text/html
|
@cstrahan pointed out that it was actually removed from the patch file itself as opposed to what gets patched by it. My bad not noticing that it can stay like this no problem. |
Per reviewer feedback, thanks! Co-Authored-By: dtzWill <github@wdtz.org>
|
Thanks, all! \o/ |
Motivation for this change
libnm-glib has been deprecated for 5 years, don't build support for ithttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/raw/1.18.0/NEWS
Things done
(following is marked based on my testing with a similar branch,
but not exactly current 'staging'. FWIW.)
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)FWIW been using this on my system since packaging it yesterday morning.