Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mumble: incompatible protobuf version #60062

Merged
merged 1 commit into from Apr 22, 2019
Merged

mumble: incompatible protobuf version #60062

merged 1 commit into from Apr 22, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Apr 22, 2019 •
edited

Motivation for this change

Fix #60013
Also see : mumble-voip/mumble#3617

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

mumble test is running OK

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre mentioned this pull request Apr 22, 2019
Closed
@worldofpeace worldofpeace merged commit 1e25e3c into NixOS:master Apr 22, 2019
@worldofpeace
Copy link
Contributor

Thanks @nyanloutre ✨

@nyanloutre nyanloutre deleted the mumble_fix branch April 23, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mumble fails to build
2 participants
@nyanloutre @worldofpeace