Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify: add libnotify as dependency #60020

Merged
merged 1 commit into from Apr 22, 2019
Merged

spotify: add libnotify as dependency #60020

merged 1 commit into from Apr 22, 2019

Conversation

bebehei
Copy link
Contributor

@bebehei bebehei commented Apr 22, 2019

Motivation for this change

The option Show desktop notification when the song changes will only
work, when libnotify is available in spotify.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bebehei
spotify: add libnotify as dependency
7a5dcb7 
The option "Show desktop notification when the song changes" will only
work, when libnotify is available in spotify.
@grahamc grahamc merged commit 73debdc into NixOS:master Apr 22, 2019
@grahamc
Copy link
Member

grahamc commented Apr 22, 2019

Thank you!

@bebehei bebehei deleted the spotify-libnotify branch April 22, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bebehei @grahamc @GrahamcOfBorg