@aanderse Thanks for the cleanup!

I tried adding a simple nixos test, but couldn't get it to work…

Also noticed there wasn't any output logged. Maybe something is wrong with how configuration is passed to it?

@flokli You'll notice I removed the openFirewall option. I did this because

1. The port is 6789, not 8989 like the service said.
2. The user will configure the port within the application itself so not much point to hard code an assumption like that.

I'd recommend running this for the curl test: curl -u nzbget:tegbzn6789 127.0.0.1:6789 | grep "This file is part of nzbget. See <http://nzbget.net>."

In lack of a better idea, I did use a lib.mkForce to exclude unrar in nzbget's path in the vm test.

While doing so, I also noticed we did rely on coreutils being in path - I made this explicit.

@GrahamcOfBorg test nzbget

@flokli your changes LGTM 👍
So... squash & merge, then a 19.03 breakfix backport because the service is unusable as it stands?

I think we might want some mkRemovedOptionModule here. There might still be some users who update from older releases who use this service, and it's good practice to not remove options without adding one of those.

I think we might want some mkRemovedOptionModule here. There might still be some users who update from older releases who use this service, and it's good practice to not remove options without adding one of those.

Fair. Addressed in latest commit.

@aanderse would you be up to adding something to the 19.09 changelog docs?

@aanderse would you be up to adding something to the 19.09 changelog docs?

Sure I'll get to it later today. Given this is broken in 19.03 is the plan still to backport? If so is the 19.09 release notes the most appropriate place?

@GrahamcOfBorg test nzbget

Sure I'll get to it later today. Given this is broken in 19.03 is the plan still to backport? If so is the 19.09 release notes the most appropriate place?

I'm not sure if we decided on a process for that. I'd say if it'll be backported to 19.03 too, it should be in the 19.03 changelog.

Problem is that we already released 19.03, so theoretically somebody who already updated to 19.03, had nzbget running, and updates the channel after this is backported, might run into problems.

However, given nzbget is pretty broken in 19.03 anyways, I doubt anybody uses it currently, and unbreaking it is fine - but I think we should get some decision from @samueldr or @lheckemann…

I think the NixOS modules system is composable enough so that one would be able to import master's module for nzbget. If it works as expected, I would go against backporting this. Otherwise, it's not really scary, probably more rude than anything. Though I'm not sure how I'd like the precedent this would cause.

In that case, let's not backport, only merge into master and add the changelog to 19.09 (like this PR already does).

Yeah that makes sense. Thanks all!