Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waf: make reproducible #60022

Merged
merged 1 commit into from Apr 22, 2019
Merged

waf: make reproducible #60022

merged 1 commit into from Apr 22, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 22, 2019

Motivation for this change

Make waf reproducible.

Please test to see if this is reproducible on your system:

grep REVISION= $(nix-build . -A waf )

I hope you get REVISION="492eeeb1294054d82d4520c9c5990db3".

aanderse
aanderse approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to reproduce 👍

@grahamc
Copy link
Member Author

grahamc commented Apr 22, 2019

PR upstreamed https://gitlab.com/ita1024/waf/merge_requests/2227

@grahamc grahamc changed the base branch from master to staging April 22, 2019 13:11
@grahamc grahamc removed the request for review from vrthra April 22, 2019 14:44
@grahamc
Copy link
Member Author

grahamc commented Apr 22, 2019 •
edited

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from vrthra April 22, 2019 16:03
@grahamc grahamc merged commit f9ef865 into NixOS:staging Apr 22, 2019
@grahamc grahamc deleted the waf branch April 22, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @aanderse @GrahamcOfBorg