Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/httpd: cleanup old apache2.2 syntax #60021

Merged
merged 1 commit into from Jun 6, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 22, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@GrahamcOfBorg test subversion upnp

@aanderse
Copy link
Member Author

@fadenb Thanks. Nice to have a second set of eyes. I haven't gotten around to running my apache configs through this just to be sure... will soon hopefully.

@aanderse aanderse marked this pull request as ready for review May 29, 2019 17:20
@aanderse aanderse merged commit fae95c2 into NixOS:master Jun 6, 2019
@aanderse aanderse deleted the httpd-cleanup branch June 7, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants