[ElementTiming] Add intersectionRect for text entries #17328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 13, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1658630
branch
3 times, most recently
from
7c11a29
to
bac7d4b
Compare
This CL adds support for intersectionRect for PerformanceElementTiming entries referring to text elements. The rect is different from the one used by Largest Contentful Paint because it does not get projected to the top-level frame, as that is not acceptable from security/privacy perspective. However the rect is only computed when needed. Bug: 942033, 969174 Change-Id: I1f09288b17a73c84daf8cc55996b78e44739a042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658630 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#669777}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1658630
branch
from
bac7d4b
to
9e2a9d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for intersectionRect for PerformanceElementTiming
entries referring to text elements. The rect is different from the one
used by Largest Contentful Paint because it does not get projected to
the top-level frame, as that is not acceptable from security/privacy
perspective. However the rect is only computed when needed.
Bug: 942033, 969174
Change-Id: I1f09288b17a73c84daf8cc55996b78e44739a042
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658630
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669777}